feat: m2m rest client#47
Open
nurtai325 wants to merge 35 commits into
Open
Conversation
nurtai325
force-pushed
the
feature/m2m-rest-client
branch
from
eadf0a9 to
ea98fac
Compare
lis0x90
reviewed
May 5, 2026
| public DbaasClient build() { | ||
| String url = config.dbaasAgentUrl().orElse(DEFAULT_DBAAS_AGENT_ADDRESS); | ||
| OkHttpClient httpClient = new OkHttpClient.Builder() | ||
| System.setProperty(M2MClientFactory.DBAAS_AGENT_URL_PROP, url); |
Member
There was a problem hiding this comment.
This is global and may affect on other tests.
lis0x90
reviewed
May 5, 2026
| return M2MClientFactory.getM2mOkHttpClient(() -> M2MManager.getInstance().getToken().getTokenValue()) | ||
| .newBuilder() | ||
| .retryOnConnectionFailure(true) | ||
| .sslSocketFactory(TlsUtils.getSslContext().getSocketFactory(), TlsUtils.getTrustManager()) |
Contributor
Author
There was a problem hiding this comment.
I just saw that at another place. Should I remove it?
nurtai325
force-pushed
the
feature/m2m-rest-client
branch
from
b7d4a55 to
77b3a61
Compare
This reverts commit a8897e8.
nurtai325
force-pushed
the
feature/m2m-rest-client
branch
from
229ef4b to
4f42660
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use new Kubernetes tokens instead of old m2m tokens in rest clients. We expect the new libraries to be used with new core versions so no fallback to old method considered. Also make unit test mock servers validate the token